🌱 Dockerfile: add the ARG defaulting within the Dockerfile #2751
Conversation
Add the default value for `GO_VERSION` within the Dockerfile to
fix build checks warnings that come from an empty variable. This
doesn’t break existing behavior; version control is still managed
by the Makefile
```
- InvalidDefaultArgInFrom: Default value for ARG \
golang:${GO_VERSION} results in empty or invalid base image name (line 17)
```
Signed-off-by: Feruzjon Muyassarov <[email protected]>
✅ Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/XS
|
/assign @lentzi90 |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lentzi90 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
I will update soon to 1.24.8 when it releases, I will remember to do that |
Right. But even if it is missed accidentally, it should not cause a problem assuming the version will be passed from the Makefile. |
What this PR does / why we need it:
Add the default value for
GO_VERSIONwithin the Dockerfile to fix build checks warnings that come from an empty variable. This doesn’t break existing behavior; version control is still managed by the MakefileWhich issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #